[WTF-2115] Generate types for editable images and files#159
Merged
LEGIO-SEXTA-FERRATA merged 7 commits intomasterfrom Mar 5, 2026
Merged
[WTF-2115] Generate types for editable images and files#159LEGIO-SEXTA-FERRATA merged 7 commits intomasterfrom
LEGIO-SEXTA-FERRATA merged 7 commits intomasterfrom
Conversation
Collaborator
|
To include the new types we will need to raise the minimum version of the |
alihcsumer
force-pushed
the
wtf/editablefiles
branch
7 times, most recently
from
44ddc00 to
52b27e6
Compare
mlaponder
requested changes
Mar 5, 2026
packages/pluggable-widgets-tools/src/typings-generator/__tests__/outputs/file.ts
Outdated
Show resolved
Hide resolved
packages/pluggable-widgets-tools/src/typings-generator/__tests__/outputs/file.ts
Outdated
Show resolved
Hide resolved
packages/pluggable-widgets-tools/src/typings-generator/generateClientTypes.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
There is a " merge branch master into" in the commits, can we make it disappear (we need a rebase anyway to resolve the conflict) |
Collaborator
|
We need to add a CHANGELOG entry |
alihcsumer
force-pushed
the
wtf/editablefiles
branch
from
7110b09 to
6b2d838
Compare
alihcsumer
force-pushed
the
wtf/editablefiles
branch
from
6b2d838 to
0f2da38
Compare
alihcsumer
force-pushed
the
wtf/editablefiles
branch
from
0f2da38 to
7494c45
Compare
mlaponder
approved these changes
Mar 5, 2026
LEGIO-SEXTA-FERRATA
approved these changes
Mar 5, 2026
LEGIO-SEXTA-FERRATA
added a commit
that referenced
this pull request
Mar 5, 2026
## Checklist - Contains unit tests ✅ ❌ - Contains breaking changes ✅ ❌ - Compatible with: MX 7️⃣, 8️⃣, 9️⃣ - Did you update version and changelog? ✅ ❌ - PR title properly formatted (`[XX-000]: description`)? ✅ ❌ ## This PR contains - [ ] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Other (describe) ## What is the purpose of this PR? It will be possible to edit file and image properties. This PR updates the typing accordingly. ## Relevant changes Type generation will now consider allowUpload attribute in the XML to generate the typings for file and image properties. ## What should be covered while testing? _..._ ## Extra comments (optional) _Please add extra comments or delete the section if not required_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅ ❌This PR contains
What is the purpose of this PR?
It will be possible to edit file and image properties. This PR updates the typing accordingly.
Relevant changes
Type generation will now consider allowUpload attribute in the XML to generate the typings for file and image properties.
What should be covered while testing?
...
Extra comments (optional)
Please add extra comments or delete the section if not required